[
https://issues.apache.org/jira/browse/HBASE-5737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250896#comment-13250896
]
ramkrishna.s.vasudevan edited comment on HBASE-5737 at 4/10/12 6:09 PM:
------------------------------------------------------------------------
Pls review the latest one. If you feel still TreeMap change is not needed, i
think the other changes are needed.
{edit}
Pls review the latest one. If you feel still TreeMap change is not needed, i
think the other changes are needed like
{code}
this.balancer.setMasterServices(this);
{code}
This is needed because as part of join cluster we call assign(). If we extend
the load balancer and want to use the masterservices we will not be able to use
it. Hence the change is needed.
{edit}
was (Author: ram_krish):
Pls review the latest one. If you feel still TreeMap change is not needed,
i think the other changes are needed.
> Minor Improvements related to balancer.
> ---------------------------------------
>
> Key: HBASE-5737
> URL: https://issues.apache.org/jira/browse/HBASE-5737
> Project: HBase
> Issue Type: Improvement
> Components: master
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Priority: Minor
> Attachments: HBASE-5737.patch, HBASE-5737_1.patch
>
>
> Currently in Am.getAssignmentByTable() we use a result map which is currenly
> a hashmap. It could be better if we have a treeMap. Even in
> MetaReader.fullScan we have the treeMap only so that we have the naming order
> maintained. I felt this change could be very useful in cases where we are
> extending the DefaultLoadBalancer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
