[
https://issues.apache.org/jira/browse/HBASE-5737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250946#comment-13250946
]
Hadoop QA commented on HBASE-5737:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12522142/HBASE-5737_1.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestAssignmentManager
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/1467//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/1467//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/1467//console
This message is automatically generated.
> Minor Improvements related to balancer.
> ---------------------------------------
>
> Key: HBASE-5737
> URL: https://issues.apache.org/jira/browse/HBASE-5737
> Project: HBase
> Issue Type: Improvement
> Components: master
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Priority: Minor
> Attachments: HBASE-5737.patch, HBASE-5737_1.patch
>
>
> Currently in Am.getAssignmentByTable() we use a result map which is currenly
> a hashmap. It could be better if we have a treeMap. Even in
> MetaReader.fullScan we have the treeMap only so that we have the naming order
> maintained. I felt this change could be very useful in cases where we are
> extending the DefaultLoadBalancer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
