ramkrish86 commented on a change in pull request #868: HBASE-23296 Add
CompositeBucketCache to support tiered BC
URL: https://github.com/apache/hbase/pull/868#discussion_r351414048
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java
##########
@@ -38,345 +32,15 @@
* Metrics are the combined size and hits and misses of both caches.
*/
@InterfaceAudience.Private
-public class CombinedBlockCache implements ResizableBlockCache, HeapSize {
- protected final FirstLevelBlockCache l1Cache;
- protected final BlockCache l2Cache;
- protected final CombinedCacheStats combinedCacheStats;
+public class CombinedBlockCache extends CompositeBlockCache implements
ResizableBlockCache {
Review comment:
So compositeBlockCache is the base now. CombinedBlockCache is a type of it.
good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
