ramkrish86 commented on a change in pull request #868: HBASE-23296 Add CompositeBucketCache to support tiered BC URL: https://github.com/apache/hbase/pull/868#discussion_r351425671
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CompositeBucketCache.java ########## @@ -0,0 +1,40 @@ +/** + * Copyright The Apache Software Foundation + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with this + * work for additional information regarding copyright ownership. The ASF + * licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + */ +package org.apache.hadoop.hbase.io.hfile; + +import org.apache.hadoop.hbase.io.hfile.bucket.BucketCache; +import org.apache.yetus.audience.InterfaceAudience; + [email protected] +public class CompositeBucketCache extends CompositeBlockCache { + public static final String IOENGINE_L1 = "hbase.bucketcache.l1.ioengine"; + public static final String IOENGINE_L2 = "hbase.bucketcache.l2.ioengine"; + public static final String CACHESIZE_L1 = "hbase.bucketcache.l1.size"; + public static final String CACHESIZE_L2 = "hbase.bucketcache.l2.size"; + public static final String WRITER_THREADS_L1 = "hbase.bucketcache.l1.writer.threads"; + public static final String WRITER_THREADS_L2 = "hbase.bucketcache.l2.writer.threads"; + public static final String WRITER_QUEUE_LENGTH_L1 = "hbase.bucketcache.l1.writer.queuelength"; + public static final String WRITER_QUEUE_LENGTH_L2 = "hbase.bucketcache.l2.writer.queuelength"; + public static final String PERSISTENT_PATH_L1 = "hbase.bucketcache.l1.persistent.path"; + public static final String PERSISTENT_PATH_L2 = "hbase.bucketcache.l2.persistent.path"; + + public CompositeBucketCache(BucketCache l1Cache, BucketCache l2Cache) { + super(l1Cache, l2Cache); Review comment: When the L1\2 Bucket cache emits the statistics - you may have to log it with the the level of the cache info also? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
