bharathv commented on a change in pull request #880: HBASE-18382 add transport
type info into Thrift UI
URL: https://github.com/apache/hbase/pull/880#discussion_r351414082
##########
File path: hbase-thrift/src/main/resources/hbase-webapps/thrift/thrift.jsp
##########
@@ -31,9 +31,12 @@ long startcode = conf.getLong("startcode",
System.currentTimeMillis());
String listenPort = conf.get("hbase.regionserver.thrift.port", "9090");
String serverInfo = listenPort + "," + String.valueOf(startcode);
ImplType implType = ImplType.getServerImpl(conf);
-String framed = implType.isAlwaysFramed()
- ? "true" : conf.get("hbase.regionserver.thrift.framed", "false");
-String compact = conf.get("hbase.regionserver.thrift.compact", "false");
+String framed = (implType.isAlwaysFramed()
+ ? "true" : conf.get("hbase.regionserver.thrift.framed", "false"))
Review comment:
"true" -> "Framed"?
nit: I think the logic has become nested and is unreadable for a ternary
operator. Mind switching to an if-else?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
