bharathv commented on a change in pull request #880: HBASE-18382 add transport
type info into Thrift UI
URL: https://github.com/apache/hbase/pull/880#discussion_r351422319
##########
File path: hbase-thrift/src/main/resources/hbase-webapps/thrift/thrift.jsp
##########
@@ -112,14 +115,19 @@ String compact =
conf.get("hbase.regionserver.thrift.compact", "false");
<td>Thrift RPC engine implementation type chosen by this Thrift
server</td>
</tr>
<tr>
- <td>Compact Protocol</td>
+ <td>Protocol</td>
<td><%= compact %></td>
- <td>Thrift RPC engine uses compact protocol</td>
+ <td>Thrift RPC engine protocol type</td>
</tr>
<tr>
- <td>Framed Transport</td>
+ <td>Transport</td>
<td><%= framed %></td>
- <td>Thrift RPC engine uses framed transport</td>
+ <td>Thrift RPC engine transport type</td>
+ </tr>
+ <tr>
+ <td>Quality Of Protection</td>
+ <td><%= qop %></td>
+ <td>QOP settings for SASL </td>
Review comment:
nit: extra space after SASL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
