ndimiduk commented on a change in pull request #830: HBASE-23281: Track meta
region locations in masters
URL: https://github.com/apache/hbase/pull/830#discussion_r353384464
##########
File path:
hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKWatcher.java
##########
@@ -384,13 +378,32 @@ public String prefix(final String str) {
*/
public List<String> getMetaReplicaNodes() throws KeeperException {
List<String> childrenOfBaseNode = ZKUtil.listChildrenNoWatch(this,
znodePaths.baseZNode);
+ return filterMetaReplicaNodes(childrenOfBaseNode);
+ }
+
+ /**
+ * Same as {@link #getMetaReplicaNodes()} except that this also registers a
watcher on base znode
+ * for subsequent CREATE/DELETE operations on child nodes.
+ */
+ public List<String> getMetaReplicaNodesAndWatchChildren() throws
KeeperException {
+ List<String> childrenOfBaseNode =
+ ZKUtil.listChildrenAndWatchForNewChildren(this, znodePaths.baseZNode);
+ return filterMetaReplicaNodes(childrenOfBaseNode);
+ }
+
+ /**
+ * @param nodes Input list of znodes
+ * @return Filtered list of znodes from nodes that belong to meta replica(s).
+ */
+ private List<String> filterMetaReplicaNodes(List<String> nodes) {
+ if (nodes == null || nodes.isEmpty()) {
+ return new ArrayList<>();
+ }
List<String> metaReplicaNodes = new ArrayList<>(2);
- if (childrenOfBaseNode != null) {
- String pattern =
conf.get("zookeeper.znode.metaserver","meta-region-server");
- for (String child : childrenOfBaseNode) {
- if (child.startsWith(pattern)) {
- metaReplicaNodes.add(child);
- }
+ String pattern =
conf.get("zookeeper.znode.metaserver","meta-region-server");
Review comment:
nit: this class, or
hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZNodePaths.java
should own this configuration point and its default value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
