ndimiduk commented on a change in pull request #917: HBASE-23383 [hbck2]
`fixHoles` should queue assignment procedures for any regions its fixing
URL: https://github.com/apache/hbase/pull/917#discussion_r356332104
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/TruncateTableProcedure.java
##########
@@ -139,7 +140,10 @@ protected Flow executeFromState(final MasterProcedureEnv
env, TruncateTableState
break;
case TRUNCATE_TABLE_ASSIGN_REGIONS:
CreateTableProcedure.setEnablingState(env, getTableName());
-
addChildProcedure(env.getAssignmentManager().createRoundRobinAssignProcedures(regions));
+ final TransitRegionStateProcedure[] assignments =
env.getAssignmentManager()
+ .createRoundRobinAssignProcedures(regions)
+ .toArray(new TransitRegionStateProcedure[0]);
+ addChildProcedure(assignments);
Review comment:
I've been using `List` but the interfaces here demand arrays. This is where
the two interfaces are reconciled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
