ndimiduk commented on a change in pull request #917: HBASE-23383 [hbck2]
`fixHoles` should queue assignment procedures for any regions its fixing
URL: https://github.com/apache/hbase/pull/917#discussion_r356294539
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MetaFixer.java
##########
@@ -244,4 +347,47 @@ static boolean isOverlap(RegionInfo ri, Pair<RegionInfo,
RegionInfo> pair) {
}
return ri.isOverlap(pair.getFirst()) || ri.isOverlap(pair.getSecond());
}
+
+ /**
+ * A union over {@link L} and {@link R}.
+ */
+ private static class Either<L, R> {
Review comment:
It belongs in `java.lang` but I digress. I'd rather not promote the class
until it has need elsewhere, and I've not performed an exhaustive review to see
if we have similar code tucked into some other nook. If you don't mind leaving
it here for now, I'll make a task of extracting this up to a type commons
module.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
