busbey commented on a change in pull request #916: HBASE-23382: Clean up
Logging for Some of hbase-server Module
URL: https://github.com/apache/hbase/pull/916#discussion_r356352368
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZKSplitLogManagerCoordination.java
##########
@@ -182,9 +181,11 @@ public boolean resubmitTask(String path, Task task,
ResubmitDirective directive)
details.getMaster().getServerManager() != null ?
details.getMaster().getServerManager()
.isServerOnline(task.cur_worker_name) : true;
if (alive && time < timeout) {
- LOG.trace("Skipping the resubmit of " + task.toString() + " because
the server "
- + task.cur_worker_name + " is not marked as dead, we waited for "
+ time
- + " while the timeout is " + timeout);
+ if (LOG.isTraceEnabled()) {
Review comment:
Skip the guard and use substitution
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
