busbey commented on a change in pull request #916: HBASE-23382: Clean up
Logging for Some of hbase-server Module
URL: https://github.com/apache/hbase/pull/916#discussion_r356405455
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/ChecksumUtil.java
##########
@@ -181,9 +181,13 @@ static boolean validateChecksum(ByteBuff buf, String
pathName, long offset, int
assert dataChecksum != null;
int onDiskDataSizeWithHeader =
buf.getInt(HFileBlock.Header.ON_DISK_DATA_SIZE_WITH_HEADER_INDEX);
- LOG.trace("dataLength={}, sizeWithHeader={}, checksumType={}, file={}, "
- + "offset={}, headerSize={}, bytesPerChecksum={}", buf.capacity(),
onDiskDataSizeWithHeader,
- ctype.getName(), pathName, offset, hdrSize, bytesPerChecksum);
+ if (LOG.isTraceEnabled()) {
Review comment:
skip the guard?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
