busbey commented on a change in pull request #916: HBASE-23382: Clean up
Logging for Some of hbase-server Module
URL: https://github.com/apache/hbase/pull/916#discussion_r356400528
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/backup/HFileArchiver.java
##########
@@ -493,25 +495,26 @@ private static boolean resolveAndArchiveFile(Path
archiveDir, File currentFile,
// really, really unlikely situtation, where we get the same name for the
existing file, but
// is included just for that 1 in trillion chance.
if (fs.exists(archiveFile)) {
- LOG.debug("{} already exists in archive, moving to timestamped backup
and " +
- "overwriting current.", archiveFile);
+ LOG.debug("File {} already exists in archive, moving to timestamped
backup and "
+ + "overwriting current",
+ archiveFile);
// move the archive file to the stamped backup
Path backedupArchiveFile = new Path(archiveDir, filename + SEPARATOR +
archiveStartTime);
if (!fs.rename(archiveFile, backedupArchiveFile)) {
- LOG.error("Could not rename archive file to backup: " +
backedupArchiveFile
+ LOG.error("Failed to rename archive file to backup: " +
backedupArchiveFile
Review comment:
use substitution
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
