ramkrish86 commented on a change in pull request #939: HBASE-23349 : Notify readers if archival of compacted store files is stuck due to scanners URL: https://github.com/apache/hbase/pull/939#discussion_r358167281
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java ########## @@ -157,6 +158,15 @@ private final ReentrantLock flushLock = new ReentrantLock(); // lock for closing. private final ReentrantLock closeLock = new ReentrantLock(); + // scanner reset lock - ensure scanners are reopened only on new store files(non compacted) + private final ReentrantLock SCANNER_RESET_LOCK = new ReentrantLock(); Review comment: Generally these are not static final variables. So you can follow the normal variable naming convention here. Need not be in CAPS. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
