ramkrish86 commented on a change in pull request #939: HBASE-23349 : Notify
readers if archival of compacted store files is stuck due to scanners
URL: https://github.com/apache/hbase/pull/939#discussion_r360485363
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ChangedReadersObserver.java
##########
@@ -40,5 +40,16 @@
* @param memStoreScanners scanner of current memstore
* @throws IOException e
*/
- void updateReaders(List<HStoreFile> sfs, List<KeyValueScanner>
memStoreScanners) throws IOException;
+ void updateReaders(List<HStoreFile> sfs, List<KeyValueScanner>
memStoreScanners)
Review comment:
Create a POJO and use it to pass the list of store files, list of
memstoreScanners and a boolean to indicate if it is flush/compaction. Act
accordingly in the Storesscanner? It will avoid having duplicate methods. Down
in StoreScanner the volatile can be renamed accordingly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
