busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB
compactions
URL: https://github.com/apache/hbase/pull/921#discussion_r359008713
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobStoreEngine.java
##########
@@ -22,14 +22,15 @@
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.hbase.regionserver.DefaultStoreEngine;
import org.apache.hadoop.hbase.regionserver.HStore;
+import org.apache.hadoop.hbase.util.ReflectionUtils;
import org.apache.yetus.audience.InterfaceAudience;
/**
* MobStoreEngine creates the mob specific compactor, and store flusher.
*/
@InterfaceAudience.Private
public class MobStoreEngine extends DefaultStoreEngine {
-
+ public final static String DEFAULT_MOB_COMPACTOR_CLASS_KEY =
"hbase.mob.default.compactor";
Review comment:
this config is setting what we use for the mob compactor right? "default" is
just a part of the current out of the box implementation? The equivalent config
for non-mob stores is `hbase.hstore.defaultengine.compactor.class`. I think
that means "hbase.hstore.mobengine.compactor.class" would be a better config.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
