busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB
compactions
URL: https://github.com/apache/hbase/pull/921#discussion_r359013974
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java
##########
@@ -326,47 +485,101 @@ protected boolean performCompaction(FileDetails fd,
InternalScanner scanner, Cel
progress.cancel();
throw new InterruptedIOException(
"Interrupted while control throughput of compacting " +
compactionName);
+ } catch (IOException t) {
+ LOG.error("Mob compaction failed for region:{} ",
store.getRegionInfo().getEncodedName());
Review comment:
We don't need to log here because the exception we throw will eventually get
logged at ERROR by CompactSplit here:
```
} catch (IOException ex) {
IOException remoteEx =
ex instanceof RemoteException ? ((RemoteException)
ex).unwrapRemoteException() : ex;
LOG.error("Compaction failed " + this, remoteEx);
```
If we want to make sure any exception thrown out of here includes the region
name, then wrap `t` with an IOException that includes that detail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
