HorizonNet commented on a change in pull request #950: HBASE-23590 : Update
maxStoreFileRefCount to maxCompactedStoreFileRef…
URL: https://github.com/apache/hbase/pull/950#discussion_r361980654
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/RegionMetrics.java
##########
@@ -156,8 +156,8 @@ default String getNameAsString() {
int getStoreRefCount();
/**
- * @return the max reference count for any store file among all stores files
+ * @return the max reference count for any store file among all compacted
stores files
* of this region
*/
- int getMaxStoreFileRefCount();
+ int getMaxCompactedStoreFileRefCount();
Review comment:
Because `RegionMetrics` is a public interface, could you please deprecate
`getMaxStoreFileRefCount` and add `getMaxCompactedStoreFileRefCount` as a new
method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
