virajjasani commented on a change in pull request #950: HBASE-23590 : Update
maxStoreFileRefCount to maxCompactedStoreFileRef…
URL: https://github.com/apache/hbase/pull/950#discussion_r361985578
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/RegionMetrics.java
##########
@@ -156,8 +156,8 @@ default String getNameAsString() {
int getStoreRefCount();
/**
- * @return the max reference count for any store file among all stores files
+ * @return the max reference count for any store file among all compacted
stores files
* of this region
*/
- int getMaxStoreFileRefCount();
+ int getMaxCompactedStoreFileRefCount();
Review comment:
Agree with the suggestion.
This new IA method was introduced as part of Jira
[HBASE-22460](https://issues.apache.org/jira/browse/HBASE-22460) and
[HBASE-23213](https://issues.apache.org/jira/browse/HBASE-23213) which are not
part of any active release so far. Hence IMO, before 2.3.0 or 1.6.0 goes live,
ideally we should be good to make this change, but yes agree to follow standard
best practices reg such cases if we have common practice available.
On the other hand, it could be argued that we can change any Public IA
method signatures as long as they are not yet present in any active release.
cc: @apurtell @anoopsjohn
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
