saintstack commented on a change in pull request #978: HBASE-22285 A normalizer
which merges small size regions with adjacen…
URL: https://github.com/apache/hbase/pull/978#discussion_r362257639
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java
##########
@@ -241,16 +147,4 @@ public int compare(NormalizationPlan plan1,
NormalizationPlan plan2) {
Collections.sort(plans, planComparator);
return plans;
}
-
- private long getRegionSize(RegionInfo hri) {
- ServerName sn = masterServices.getAssignmentManager().getRegionStates().
- getRegionServerOfRegion(hri);
- RegionMetrics regionLoad = masterServices.getServerManager().getLoad(sn).
- getRegionMetrics().get(hri.getRegionName());
- if (regionLoad == null) {
- LOG.debug(hri.getRegionNameAsString() + " was not found in RegionsLoad");
- return -1;
- }
- return (long) regionLoad.getStoreFileSize().get(Size.Unit.MEGABYTE);
- }
Review comment:
Any chance of a test to prove the new normalizer is doing as advertised?
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
