virajjasani commented on a change in pull request #978: HBASE-22285 A
normalizer which merges small size regions with adjacen…
URL: https://github.com/apache/hbase/pull/978#discussion_r362306164
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java
##########
@@ -132,18 +107,6 @@ public int compare(NormalizationPlan plan1,
NormalizationPlan plan2) {
return null;
}
boolean splitEnabled = true, mergeEnabled = true;
- try {
- splitEnabled = masterRpcServices.isSplitOrMergeEnabled(null,
-
RequestConverter.buildIsSplitOrMergeEnabledRequest(MasterSwitchType.SPLIT)).getEnabled();
- } catch (org.apache.hbase.thirdparty.com.google.protobuf.ServiceException
e) {
- LOG.debug("Unable to determine whether split is enabled", e);
- }
- try {
- mergeEnabled = masterRpcServices.isSplitOrMergeEnabled(null,
-
RequestConverter.buildIsSplitOrMergeEnabledRequest(MasterSwitchType.MERGE)).getEnabled();
- } catch (org.apache.hbase.thirdparty.com.google.protobuf.ServiceException
e) {
- LOG.debug("Unable to determine whether merge is enabled", e);
- }
Review comment:
We have removed above block but may be missed using them.
```
boolean splitEnabled = isSplitEnabled();
boolean mergeEnabled = isMergeEnabled();
```
Without this, by default splitEnabled and mergeEnabled are always true
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
