virajjasani commented on a change in pull request #978: HBASE-22285 A
normalizer which merges small size regions with adjacen…
URL: https://github.com/apache/hbase/pull/978#discussion_r362385208
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
##########
@@ -158,6 +158,12 @@
public static final String HBASE_MASTER_NORMALIZER_CLASS =
"hbase.master.normalizer.class";
+ /** Config for min age of region before being considerded for merge in
mormalizer */
+ public static final int DEFAULT_MIN_DAYS_BEFORE_MERGE = 3;
+
+ public static final String HBASE_MASTER_DAYS_BEFORE_MERGE =
+ "hbase.master.normalize.daysBeforeMerge";
+
Review comment:
I think we can move both these constants to MergeNormalizer. If we move to
hbase-default, we don't need this constant `DEFAULT_MIN_DAYS_BEFORE_MERGE`
because `hbase.master.normalize.daysBeforeMerge` will always have value, either
from hbase-default or hbase-site
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
