bharathv commented on a change in pull request #979: HBASE-23632 DeadServer
cleanup
URL: https://github.com/apache/hbase/pull/979#discussion_r362569794
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/DeadServer.java
##########
@@ -140,12 +107,8 @@ public synchronized void add(ServerName sn) {
*/
public synchronized void notifyServer(ServerName sn) {
boolean added = processingServers.add(sn);
- if (LOG.isDebugEnabled()) {
- if (added) {
- LOG.debug("Added " + sn + "; numProcessing=" +
processingServers.size());
- }
- LOG.debug("Started processing " + sn + "; numProcessing=" +
processingServers.size());
- }
+ LOG.debug("Started processing {}; numProcessing={}; added={}",
Review comment:
nit: Please correct me if I'm wrong. Now that we use notifyServer() as a
helper in add(), calling notifyServer() doesn't mean we started processing it?
Calling notifyServer() from SCP only means we started processing it, no? My
point is log might be a little misleading.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
