saintstack commented on a change in pull request #979: HBASE-23632 DeadServer
cleanup
URL: https://github.com/apache/hbase/pull/979#discussion_r362617492
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/DeadServer.java
##########
@@ -140,12 +107,8 @@ public synchronized void add(ServerName sn) {
*/
public synchronized void notifyServer(ServerName sn) {
boolean added = processingServers.add(sn);
- if (LOG.isDebugEnabled()) {
- if (added) {
- LOG.debug("Added " + sn + "; numProcessing=" +
processingServers.size());
- }
- LOG.debug("Started processing " + sn + "; numProcessing=" +
processingServers.size());
- }
+ LOG.debug("Started processing {}; numProcessing={}; added={}",
Review comment:
Thanks. You are right. Let me make the logging note better.
Thanks for the review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
