saintstack commented on a change in pull request #958: HBASE-23584 : Descrease
rpc getFileStatus count when open a storefile
URL: https://github.com/apache/hbase/pull/958#discussion_r362646657
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileInfo.java
##########
@@ -362,21 +360,23 @@ private HDFSBlocksDistribution
computeHDFSBlocksDistributionInternal(final FileS
return FSUtils.computeHDFSBlocksDistribution(fs, status, 0,
status.getLen());
}
}
-
+
/**
* Get the {@link FileStatus} of the file referenced by this StoreFileInfo
* @param fs The current file system to use.
* @return The {@link FileStatus} of the file referenced by this
StoreFileInfo
*/
public FileStatus getReferencedFileStatus(final FileSystem fs) throws
IOException {
FileStatus status;
+ if(this.localStatus != null) {return this.localStatus;}
Review comment:
If so, make it final then we are explicit that it does not change during
life time of a StoreFileInfo instance and we are clear about its thread safety.
If done in constructor, you don't need this null check then either?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
