saintstack commented on a change in pull request #958: HBASE-23584 : Descrease rpc getFileStatus count when open a storefile URL: https://github.com/apache/hbase/pull/958#discussion_r362647394
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileInfo.java ########## @@ -107,7 +108,7 @@ private RegionCoprocessorHost coprocessorHost; - // timestamp on when the file was created, is 0 and ignored for reference or link files + // change to use the createdTimestamp of reference or link files , will it create some problem later ? Review comment: Its good to mark data members final if your intent is that they are not ever to change. It helps the compiler and it helps the dev reading the code later. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
