ndimiduk commented on a change in pull request #954: HBASE-23305: Master based
registry implementation
URL: https://github.com/apache/hbase/pull/954#discussion_r362672281
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/util/JVMClusterUtil.java
##########
@@ -136,6 +137,10 @@ public HMaster getMaster() {
} catch (Exception e) {
throw new IOException(e);
}
+ // Needed if a master based registry is configured for internal cluster
connections. Here, we
+ // just add the current master host port since we do not know other master
addresses up front
+ // in mini cluster tests.
+ c.set(HConstants.MASTER_ADDRS_KEY,
server.getServerName().getAddress().toString());
Review comment:
No null-checking required?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
