ndimiduk commented on a change in pull request #954: HBASE-23305: Master based
registry implementation
URL: https://github.com/apache/hbase/pull/954#discussion_r362675053
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/AbstractTestIPC.java
##########
@@ -363,6 +365,101 @@ public void testAsyncEcho() throws IOException {
}
}
+ /**
+ * Tests the happy path for various request fan out values using a simple
RPC hedged across
+ * a mix of running and failing servers.
+ */
+ @Test
+ public void testHedgedAsyncEcho() throws Exception {
+ List<RpcServer> rpcServers = new ArrayList<>();
+ List<InetSocketAddress> addresses = new ArrayList<>();
+ // Create a mix of running and failing servers.
+ final int numRunningServers = 5;
+ final int numFailingServers = 3;
Review comment:
If this is happy-path testing, why are there any failing servers at all?
When I think "happy path", I would expect a test with all running servers, and
assertions that (1) the correct value is received every time and (2) no more
than `fanOut` RPC calls are ever issued.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
