virajjasani commented on a change in pull request #982: HBASE-23636 Disable
table may hang when regionserver stop or abort.
URL: https://github.com/apache/hbase/pull/982#discussion_r363018415
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java
##########
@@ -482,13 +482,18 @@ private void assignRegions(MasterProcedureEnv env,
List<RegionInfo> regions) thr
regionNode.getProcedure().serverCrashed(env, regionNode,
getServerName());
continue;
}
- if
(env.getMasterServices().getTableStateManager().isTableState(regionNode.getTable(),
- TableState.State.DISABLING, TableState.State.DISABLED)) {
+ if (env.getMasterServices().getTableStateManager()
+ .isTableState(regionNode.getTable(), TableState.State.DISABLING)) {
env.getAssignmentManager().regionClosedAbnormally(regionNode);
- LOG.info("{} found table disabled for region {}, set it state to
ABNORMALLY_CLOSED.",
+ LOG.info("{} found table disabling for region {}, set it state to
ABNORMALLY_CLOSED.",
this, regionNode);
continue;
}
+ if (env.getMasterServices().getTableStateManager()
+ .isTableState(regionNode.getTable(), TableState.State.DISABLED)) {
+ LOG.warn("{} found table disabled for region {}.", this, regionNode);
Review comment:
Seems like it will print everything, is it good to log:
```
LOG.warn("Found table disabled for region {}, procDetails: {}", regionNode,
this);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
