Apache9 commented on a change in pull request #982: HBASE-23636 Disable table
may hang when regionserver stop or abort.
URL: https://github.com/apache/hbase/pull/982#discussion_r363151004
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java
##########
@@ -482,8 +482,16 @@ private void assignRegions(MasterProcedureEnv env,
List<RegionInfo> regions) thr
regionNode.getProcedure().serverCrashed(env, regionNode,
getServerName());
continue;
}
- if
(env.getMasterServices().getTableStateManager().isTableState(regionNode.getTable(),
- TableState.State.DISABLING, TableState.State.DISABLED)) {
+ if (env.getMasterServices().getTableStateManager()
+ .isTableState(regionNode.getTable(), TableState.State.DISABLING)) {
+ env.getAssignmentManager().regionClosedAbnormally(regionNode);
+ LOG.info("{} found table disabling for region {}, set it state to
ABNORMALLY_CLOSED.",
+ this, regionNode);
+ continue;
+ }
+ if (env.getMasterServices().getTableStateManager()
Review comment:
And also here, described why we do not need to set the state. I think the
state here should already be CLOSED? And I wonder whether we could reach here,
since the region is sitll in OPEN or OPENING state but the server recorded in
AM is already dead so we can not close it in TRSP...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
