anoopsjohn commented on a change in pull request #991: HBASE-23651 Region
balance throttling can be disabled
URL: https://github.com/apache/hbase/pull/991#discussion_r363578975
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##########
@@ -1688,12 +1688,8 @@ InetAddress getRemoteInetAddress(final int port,
* @return Maximum time we should run balancer for
*/
private int getMaxBalancingTime() {
- int maxBalancingTime =
getConfiguration().getInt(HConstants.HBASE_BALANCER_MAX_BALANCING, -1);
- if (maxBalancingTime == -1) {
- // if max balancing time isn't set, defaulting it to period time
- maxBalancingTime =
getConfiguration().getInt(HConstants.HBASE_BALANCER_PERIOD,
- HConstants.DEFAULT_HBASE_BALANCER_PERIOD);
- }
+ int maxBalancingTime = getConfiguration()
Review comment:
This change is wrong right? We no longer check any configured value for
HBASE_BALANCER_PERIOD.
U wanted it like
maxBalancingTime =
getConfiguration().getInt(HConstants.HBASE_BALANCER_MAX_BALANCING,
getConfiguration().getInt(HConstants.HBASE_BALANCER_PERIOD,
HConstants.DEFAULT_HBASE_BALANCER_PERIOD);
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
