anoopsjohn commented on a change in pull request #991: HBASE-23651 Region 
balance throttling can be disabled
URL: https://github.com/apache/hbase/pull/991#discussion_r363579392
 
 

 ##########
 File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
 ##########
 @@ -1860,11 +1856,14 @@ public boolean balance(boolean force) throws 
IOException {
         //rpCount records balance plans processed, does not care if a plan 
succeeds
         rpCount++;
 
-        balanceThrottling(balanceStartTime + rpCount * balanceInterval, 
maxRegionsInTransition,
+        if (this.maxBlancingTime > 0) {
 
 Review comment:
   So you will change this maxBlancingTime dynamically at HM config?  
   If permanently for the cluster the throttling needs disabled, 
hbase.master.balancer.maxRitPercent can be 100% right (which is the def value). 
 What am missing here? I did not read this part of code fully though

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to