ndimiduk commented on a change in pull request #954: HBASE-23305: Master based 
registry implementation
URL: https://github.com/apache/hbase/pull/954#discussion_r363839020
 
 

 ##########
 File path: 
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AbstractRpcClient.java
 ##########
 @@ -527,6 +528,12 @@ public RpcChannel createRpcChannel(ServerName sn, User 
user, int rpcTimeout)
     return new RpcChannelImplementation(this, createAddr(sn), user, 
rpcTimeout);
   }
 
+  @Override
+  public RpcChannel createHedgedRpcChannel(Set<ServerName> sns, User user, int 
rpcTimeout)
+      throws UnknownHostException {
+    throw new NotImplementedException("Should be called on an 
AbstractRpcClient implementation.");
 
 Review comment:
   I think you mean NettyRpcClient. Simply "method not supported for this 
implementation." is fine.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to