ndimiduk commented on a change in pull request #954: HBASE-23305: Master based
registry implementation
URL: https://github.com/apache/hbase/pull/954#discussion_r364342781
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
##########
@@ -4260,7 +4279,13 @@ public void testUnmanagedHConnection() throws
IOException {
*/
@Test
public void testUnmanagedHConnectionReconnect() throws Exception {
- final TableName tableName = TableName.valueOf(name.getMethodName());
+ Configuration conf = TEST_UTIL.getConfiguration();
+ Class registryImpl = conf.getClass(
+ HConstants.CLIENT_CONNECTION_REGISTRY_IMPL_CONF_KEY,
ZKConnectionRegistry.class);
+ // This test does not make sense for MasterRegistry since it stops the
only master in the
+ // cluster and starts a new master without populating the underlying
config for the connection.
+ Assume.assumeFalse(registryImpl.equals(MasterRegistry.class));
Review comment:
My only gripe about this is that surefire will warn about skipped methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
