Apache9 commented on a change in pull request #1011: HBASE-23055 Alter
hbase:meta
URL: https://github.com/apache/hbase/pull/1011#discussion_r365226730
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/TableStateManager.java
##########
@@ -54,8 +53,20 @@
// TODO: Make this a guava Service
@InterfaceAudience.Private
public class TableStateManager {
-
private static final Logger LOG =
LoggerFactory.getLogger(TableStateManager.class);
+
+ /**
+ * All table state is kept in hbase:meta except that of hbase:meta itself.
Review comment:
In general I do not think this is a good design. We should persist it
somewhere, and just cache it in master's memory. And we do not need to disable
a table when altering any more? And the solution here just assume that we only
have one meta region? So the altering operation can be atomic? What if we have
multiple meta regions and we crash in the middle? I think this patch also aims
to implement splittable meta in the future? No?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
