saintstack commented on a change in pull request #1011: HBASE-23055 Alter hbase:meta URL: https://github.com/apache/hbase/pull/1011#discussion_r365330389
########## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ZKAsyncRegistry.java ########## @@ -58,8 +62,19 @@ private final ZNodePaths znodePaths; + /** + * A znode maintained by MirroringTableStateManager. + * MirroringTableStateManager is deprecated to be removed in hbase3. It can also be disabled. + * Make sure it is enabled if you want to alter hbase:meta table in hbase2. In hbase3, + * TBD how metatable state will be hosted; likely on active hbase master. Review comment: The 'mirroring' feature predates this patch. This is an old facility this patch just makes use of. Changing this old features name is outside realm of this work. You get the bit that edit of meta is a rare, short-lived event and you get the bit that this implementation fails the state back to ENABLED if ever an issue, intentionally, to minimize our running into exotic situations. I don't want a permanently DISABLED state for hbase:meta, at least not at this stage in the game. We can do that later ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
