[
https://issues.apache.org/jira/browse/HBASE-23569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013846#comment-17013846
]
Viraj Jasani edited comment on HBASE-23569 at 1/13/20 2:55 AM:
---------------------------------------------------------------
If we just check that after HMaster init, choreService has LogCleaner scheduled
as part of the UT, should be good enough? Given that
# LogCleaner testing has it's own set of tests to ensure cleanup is fine
# UT might be preferable over IT since the frequency of UT run is quite high
May be it’s good to have separate UT class where majority of default/config
based chores are ensured to have been scheduled by HMaster/RegionServer and can
be used going forward by any dev while introducing new chore(default/config
based). As long as individual chore's functional testing is concerned, usually
we would have separate UT class anyways. Like for LogCleaner, we have
TestLogsCleaner to test if LogCleaner is removing oldWALs but we lack testing
of whether HMaster is scheduling LogCleaner by default. And that we can add as
part of this Jira.
Sounds good to you [~apurtell] ?
was (Author: vjasani):
If we just check that after HMaster init, choreService has LogCleaner scheduled
as part of the UT, should be good enough? Given that
# LogCleaner testing has it's own set of tests to ensure cleanup is fine
# UT might be preferable over IT since the frequency of UT run is quite high
May be it’s good to have separate UT class where majority of default/config
based chores are ensured to have been scheduled by HMaster/RegionServer and can
be used going forward by any dev while introducing new chore(default/config
based). As long as individual chore's functional testing is concerned, usually
we would have separate UT class anyways. Like for LogCleaner functionality, we
have TestLogsCleaner for testing functionality of LogCleaner but we lack
testing of whether HMaster is scheduling LogCleaner by default. And that we can
add as part of this Jira.
Sounds good to you [~apurtell] ?
> Validate that the log cleaner actually cleans oldWALs as expected
> -----------------------------------------------------------------
>
> Key: HBASE-23569
> URL: https://issues.apache.org/jira/browse/HBASE-23569
> Project: HBase
> Issue Type: Test
> Components: integration tests, master, test
> Reporter: Andrew Kyle Purtell
> Priority: Major
> Fix For: 3.0.0, 2.3.0, 1.6.0
>
>
> The fix for HBASE-23287 (LogCleaner is not added to choreService) is in but
> we are lacking test coverage that validates that the log cleaner actually
> cleans oldWALs as expected. Add the test.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
