wchevreuil commented on a change in pull request #1027: HBASE-23683 Make
HBaseInterClusterReplicationEndpoint more extensible
URL: https://github.com/apache/hbase/pull/1027#discussion_r365785358
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/HBaseInterClusterReplicationEndpoint.java
##########
@@ -113,6 +113,14 @@
private boolean dropOnDeletedTables;
private boolean isSerial = false;
+ protected Connection createConnection(Configuration conf) throws IOException
{
+ return ConnectionFactory.createConnection(conf);
+ }
+
+ protected ReplicationSinkManager
createReplicationSinkManager(AsyncClusterConnection conn) {
+ return new ReplicationSinkManager(conn,this, this.conf);
Review comment:
Fixed on last commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services