bharathv commented on a change in pull request #1027: HBASE-23683 Make
HBaseInterClusterReplicationEndpoint more extensible
URL: https://github.com/apache/hbase/pull/1027#discussion_r365994648
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/HBaseInterClusterReplicationEndpoint.java
##########
@@ -113,6 +113,15 @@
private boolean dropOnDeletedTables;
private boolean isSerial = false;
+ protected AsyncClusterConnection createConnection(Configuration conf) throws
IOException {
Review comment:
nit: Add a quick comment why these exist as protected? Otherwise it can
confuse the readers because the only callers in the source are in this class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
