busbey commented on a change in pull request #1029: HBASE-23679 FileSystem
objects leak when cleaned up in cleanupBulkLoad
URL: https://github.com/apache/hbase/pull/1029#discussion_r365960514
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SecureBulkLoadManager.java
##########
@@ -305,6 +301,13 @@ private boolean isUserReferenced(UserGroupInformation
ugi) {
});
} finally {
decrementUgiReference(ugi);
+ try {
+ if (!UserGroupInformation.getLoginUser().equals(ugi) &&
!isUserReferenced(ugi)) {
+ FileSystem.closeAllForUGI(ugi);
+ }
+ } catch (IOException e) {
+ LOG.error("Failed to close FileSystem for: " + ugi, e);
Review comment:
nit: parameterize the log message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
