joshelser commented on issue #1029: HBASE-23679 FileSystem objects leak when cleaned up in cleanupBulkLoad URL: https://github.com/apache/hbase/pull/1029#issuecomment-573831673 Thanks for the quick reviews, folks. > Maybe as future work, if it is indeed worth due to potential performance impacts (i.e. case of retries), could LoadIncrementalHFiles call the cleanup for each region involved in the bulkload, once it's done? Yeah, admittedly, I don't have a good understanding for what the performance impact is. We would have to do some new SASL handshakes to HDFS daemons, but, beyond that, I'm not sure what the actual cost is. I also did not look historically to see if this code once made sense :)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
