anoopsjohn commented on a change in pull request #1074: HBASE-23350 Make
compaction files cacheonWrite configurable based on threshold
URL: https://github.com/apache/hbase/pull/1074#discussion_r368657940
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
##########
@@ -1137,7 +1146,13 @@ public StoreFileWriter createWriterInTmp(long
maxKeyCount, Compression.Algorithm
cacheOnWriteLogged = true;
}
} else {
- writerCacheConf.setCacheDataOnWrite(false);
+ writerCacheConf.disableCacheOnWrite();
+ if (totalCompactedFileSize >
cacheConf.getCacheCompactedBlocksOnWriteThreshold()) {
Review comment:
Good.
may be we can log this line if the conf says to cache it but size is more. I
would say use INFO log then.
Also to create the msg use the log statement like above way
LOG.info("For Store {} , cacheCompactedBlocksOnWrite....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
