HorizonNet commented on a change in pull request #1074: HBASE-23350 Make
compaction files cacheonWrite configurable based on threshold
URL: https://github.com/apache/hbase/pull/1074#discussion_r370675993
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestCacheOnWrite.java
##########
@@ -508,18 +522,31 @@ private void
testCachingDataBlocksDuringCompactionInternals(boolean useTags,
"\ncacheBlocksOnCompaction: "
+ cacheBlocksOnCompaction + "\n";
- assertEquals(assertErrorMessage, cacheOnCompactAndNonBucketCache,
dataBlockCached);
+ if(cacheOnCompactAndNonBucketCache && cacheBlocksOnCompactionThreshold >
0) {
Review comment:
White space after `if`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
