virajjasani edited a comment on issue #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#issuecomment-579162619 > A couple high-level questions: > > 1. Since the detailed info is going through this ring buffer subsystem, why do we continue to log at all? Why not replace the logging with a metric? > 2. Should entries of the ring buffer expire after a period of time? 1. Ring Buffer is not a replacement of slow logs that we write to file, it's just a complete representation of slow logs, whereas in log files we might have trimmed logs. We also have plan to write all slowlogs to HDFS (optionally) and provide HDFS file path to user optionally, at that time we can think of removing logging in log files. However, I am not sure about metric. Which metric are you suggesting to expose? You mean slow logs with some parameters? 2. IMHO if we are going to achieve significant resource utilization with TTL of ring buffer entries, we can have a sub-task to this Jira, but do we really need it? I feel it's fine to let them stay in the buffer. Anyways size of the buffer and whether to even use ring buffer is up-to user. However, if required, I am fine with a sub-task.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
