[
https://issues.apache.org/jira/browse/HBASE-23811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032727#comment-17032727
]
Wei-Chiu Chuang commented on HBASE-23811:
-----------------------------------------
For JaegerTracing 1.1.0, there are:
{noformat}
[INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ hbase-jaeger ---
[INFO] org.apache.hbase.thirdparty:hbase-jaeger:jar:3.2.1-SNAPSHOT
[INFO] +- io.jaegertracing:jaeger-client:jar:1.1.0:compile
[INFO] | +- io.jaegertracing:jaeger-core:jar:1.1.0:compile
[INFO] | | +- io.opentracing:opentracing-api:jar:0.33.0:compile
[INFO] | | +- io.opentracing:opentracing-util:jar:0.33.0:compile
[INFO] | | | \- io.opentracing:opentracing-noop:jar:0.33.0:compile
[INFO] | | \- com.google.code.gson:gson:jar:2.8.6:compile
[INFO] | \- io.jaegertracing:jaeger-tracerresolver:jar:1.1.0:compile
[INFO] | \-
io.opentracing.contrib:opentracing-tracerresolver:jar:0.1.8:compile
[INFO] +- io.jaegertracing:jaeger-thrift:jar:1.1.0:compile
[INFO] | +- org.slf4j:slf4j-api:jar:1.7.28:compile
[INFO] | \- com.squareup.okhttp3:okhttp:jar:4.2.2:compile
[INFO] | +- com.squareup.okio:okio:jar:2.2.2:compile
[INFO] | \- org.jetbrains.kotlin:kotlin-stdlib:jar:1.3.50:compile
[INFO] | +- org.jetbrains.kotlin:kotlin-stdlib-common:jar:1.3.50:compile
[INFO] | \- org.jetbrains:annotations:jar:13.0:compile
[INFO] \- org.apache.thrift:libthrift:jar:0.13.0:compile
[INFO] +- org.apache.httpcomponents:httpclient:jar:4.5.6:compile
[INFO] | +- commons-logging:commons-logging:jar:1.2:compile
[INFO] | \- commons-codec:commons-codec:jar:1.10:compile
[INFO] +- org.apache.httpcomponents:httpcore:jar:4.4.1:compile
[INFO] \- javax.annotation:javax.annotation-api:jar:1.3.2:compile
{noformat}
My uber jar removes a bunch of these because hbase already ships with these
dependencies and works ok so far:
{noformat}
<exclude>org.apache.httpcomponents:httpclient</exclude>
<exclude>commons-logging:commons-logging</exclude>
<exclude>commons-codec:commons-codec</exclude>
<exclude>org.apache.httpcomponents:httpcore</exclude>
<exclude>javax.annotation:javax.annotation-api</exclude>
<exclude>org.slf4j:slf4j-api</exclude>
{noformat}
I suspect hbase-thirdparty is a better home for this uber jar but i'm happy to
relocate as long as it makes sense.
> [OpenTracing] Add shaded JaegerTracing tracer to hbase-thirdparty
> -----------------------------------------------------------------
>
> Key: HBASE-23811
> URL: https://issues.apache.org/jira/browse/HBASE-23811
> Project: HBase
> Issue Type: Sub-task
> Components: thirdparty
> Reporter: Wei-Chiu Chuang
> Assignee: Wei-Chiu Chuang
> Priority: Major
>
> JaegerTracing pulls in lots of dependencies. Some, like libthrift (0.13.0)
> conflicts the one ships in HBase (0.12.0).
> Additionally, not everyone may want to use Jaeger.
> I propose to shade JaegerTracing and its dependencies into an uber jar, place
> it as a hbase-thirdparty artifact. As an added benefit, this makes the
> management of tracers in the HBase's dependency tree much easier. Finally, we
> can follow the same suit and provide Zipkin tracer support in the future.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
