[
https://issues.apache.org/jira/browse/HBASE-23811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032743#comment-17032743
]
Michael Stack commented on HBASE-23811:
---------------------------------------
The gson dependency is problematic. HBase uses shaded gson in thirdparty.
kotlin? Sure you didn't forget the scala include (smile). For a lib that is
supposed to be low-impact, seems strange dragging in kotlin but what do I know.
The thrift dependency is a problem when it doesn't agree w/ what we ship.
Yeah, add to thirdparty I'd say to be safe sir. Shout if issues.
> [OpenTracing] Add shaded JaegerTracing tracer to hbase-thirdparty
> -----------------------------------------------------------------
>
> Key: HBASE-23811
> URL: https://issues.apache.org/jira/browse/HBASE-23811
> Project: HBase
> Issue Type: Sub-task
> Components: thirdparty
> Reporter: Wei-Chiu Chuang
> Assignee: Wei-Chiu Chuang
> Priority: Major
>
> JaegerTracing pulls in lots of dependencies. Some, like libthrift (0.13.0)
> conflicts the one ships in HBase (0.12.0).
> Additionally, not everyone may want to use Jaeger.
> I propose to shade JaegerTracing and its dependencies into an uber jar, place
> it as a hbase-thirdparty artifact. As an added benefit, this makes the
> management of tracers in the HBase's dependency tree much easier. Finally, we
> can follow the same suit and provide Zipkin tracer support in the future.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
