virajjasani commented on a change in pull request #754: HBASE-22978 : Online
slow response log
URL: https://github.com/apache/hbase/pull/754#discussion_r378660761
##########
File path:
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/client/ThriftAdmin.java
##########
@@ -1157,6 +1158,18 @@ public boolean isSnapshotCleanupEnabled() {
throw new NotImplementedException("isSnapshotCleanupEnabled not supported
in ThriftAdmin");
}
+ @Override
+ public List<SlowLogPayload> getSlowLogResponses(final List<ServerName>
serverNames)
+ throws IOException {
+ throw new NotImplementedException("getSlowLogResponses not supported in
ThriftAdmin");
Review comment:
I am not sure if it is deprecated but for at least 1 year, I have not seen
much of APIs getting implemented here, if you see, majority of APIs on this
file have "not supported in ThriftAdmin". Only earlier APIs like schema related
ops create, alter etc are implemented here.
Anyways, I am fine with taking this in follow up work, sir @ndimiduk . Your
call :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
