virajjasani commented on a change in pull request #754: HBASE-22978 : Online
slow response log
URL: https://github.com/apache/hbase/pull/754#discussion_r379771274
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncAdmin.java
##########
@@ -1507,4 +1507,24 @@
*/
CompletableFuture<Boolean> isSnapshotCleanupEnabled();
+ /**
+ * Retrieves online slowlog responses from in memory ringbuffer maintained by
+ * RegionServers
+ *
+ * @param serverNames Server names to get slowlog responses from
+ * @param slowLogQueryFilter filter to be used if provided
+ * @return Online slowlog response list. The return value wrapped by a
{@link CompletableFuture}
+ */
+ CompletableFuture<List<SlowLogRecord>> getSlowLogResponses(final
List<ServerName> serverNames,
Review comment:
Since we are maintaining ringbuffer, we are not really much interested with
duplicates and even some missing events. Eventually, for any slower RPC calls,
these APIs should provide hints good enough for user to perform immediate
remediations specifically when system is really slow. Duplicates are fine but
we are less likely to get duplicates unless RpcServer itself sends duplicate
events. The reason why we should not prefer Set<> is because we want to
maintain order also, better to display latest records first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
