bharathv commented on a change in pull request #754: HBASE-22978 : Online slow
response log
URL: https://github.com/apache/hbase/pull/754#discussion_r379698898
##########
File path:
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/client/ThriftAdmin.java
##########
@@ -1157,6 +1158,18 @@ public boolean isSnapshotCleanupEnabled() {
throw new NotImplementedException("isSnapshotCleanupEnabled not supported
in ThriftAdmin");
}
+ @Override
+ public List<SlowLogPayload> getSlowLogResponses(final List<ServerName>
serverNames)
+ throws IOException {
+ throw new NotImplementedException("getSlowLogResponses not supported in
ThriftAdmin");
Review comment:
Ya, I had a similar question about thrift interface when I was working on
HBASE-23330, but it looks like it is supported. So we should probably do this
too.. it is not too much code right? (just defining the equivalent thrift
specs).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
