bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r379685711
########## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/SlowLogParams.java ########## @@ -0,0 +1,89 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hbase.client; + +import org.apache.commons.lang3.StringUtils; +import org.apache.commons.lang3.builder.EqualsBuilder; +import org.apache.commons.lang3.builder.HashCodeBuilder; +import org.apache.commons.lang3.builder.ToStringBuilder; +import org.apache.yetus.audience.InterfaceAudience; + +/** + * SlowLog params object that contains detailed info as params and region name : to be used + * for filter purpose + */ +@InterfaceAudience.Private +public class SlowLogParams { Review comment: I have this very basic question(may be discussed elsewhere but I don't see it)..why does everything contain"log" SlowLogParams SlowLogResponses SlowLogQueryFilter... Reading through the jira, I think we should be calling it SlowRequestBuffer or something like that? I don't understand the "log" part here.. reading through the patch, it looks like we are book-keeping this data *after* the logging is done, right? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
