wchevreuil commented on a change in pull request #1174: HBASE-23827 [HBCK2] Add mergeRegions method to hbck service URL: https://github.com/apache/hbase/pull/1174#discussion_r380624073
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java ########## @@ -2458,6 +2443,48 @@ public FileArchiveNotificationResponse reportFileArchival(RpcController controll // HBCK Services + @Override + public MergeTableRegionsResponse mergeRegions(RpcController c, MergeTableRegionsRequest request) Review comment: Found a bit confusing to have two merge methods. Should we just simplify this Master API by keeping the new merge method only? I mean, if it is possible to do merges without master fully initialised, then why should we bother enforcing it? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
